Fixes http endpoint being overwritten by gRPC address argument in constructor #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
elena-kolevska
changed the title
elena-kolevska
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.11 #621 +/- ##
===============================================
Coverage ? 86.41%
===============================================
Files ? 74
Lines ? 3592
Branches ? 0
===============================================
Hits ? 3104
Misses ? 488
Partials ? 0 ☔ View full report in Codecov by Sentry. |
…figured Signed-off-by: Elena Kolevska <[email protected]>
artursouza
approved these changes
Oct 19, 2023
berndverst
reviewed
Oct 31, 2023
Signed-off-by: Bernd Verst <[email protected]>
berndverst
approved these changes
Oct 31, 2023
elena-kolevska
added a commit
to elena-kolevska/python-sdk
that referenced
this pull request
Feb 7, 2024
…structor (dapr#621) * Fixes bug of constructor argument being used as http endpoint Signed-off-by: Elena Kolevska <[email protected]> * Updates tests Signed-off-by: Elena Kolevska <[email protected]> * Updates the docs explaining how http service invocation should be configured Signed-off-by: Elena Kolevska <[email protected]> * Update daprdocs/content/en/python-sdk-docs/python-client.md Signed-off-by: Bernd Verst <[email protected]> --------- Signed-off-by: Elena Kolevska <[email protected]> Signed-off-by: Bernd Verst <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Elena Kolevska <[email protected]> # Conflicts: # dapr/clients/__init__.py # dapr/clients/http/client.py # dapr/clients/http/dapr_invocation_http_client.py # tests/clients/test_http_service_invocation_client.py # tests/clients/test_secure_http_service_invocation_client.py
elena-kolevska
added a commit
to elena-kolevska/python-sdk
that referenced
this pull request
Feb 7, 2024
…structor (dapr#621) * Fixes bug of constructor argument being used as http endpoint Signed-off-by: Elena Kolevska <[email protected]> * Updates tests Signed-off-by: Elena Kolevska <[email protected]> * Updates the docs explaining how http service invocation should be configured Signed-off-by: Elena Kolevska <[email protected]> * Update daprdocs/content/en/python-sdk-docs/python-client.md Signed-off-by: Bernd Verst <[email protected]> --------- Signed-off-by: Elena Kolevska <[email protected]> Signed-off-by: Bernd Verst <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Elena Kolevska <[email protected]> # Conflicts: # dapr/clients/__init__.py # dapr/clients/http/client.py # dapr/clients/http/dapr_invocation_http_client.py # tests/clients/test_http_service_invocation_client.py # tests/clients/test_secure_http_service_invocation_client.py
berndverst
pushed a commit
that referenced
this pull request
Feb 9, 2024
* Fixes http endpoint being overwritten by gRPC address argument in constructor (#621) * Fixes bug of constructor argument being used as http endpoint Signed-off-by: Elena Kolevska <[email protected]> * Updates tests Signed-off-by: Elena Kolevska <[email protected]> * Updates the docs explaining how http service invocation should be configured Signed-off-by: Elena Kolevska <[email protected]> * Update daprdocs/content/en/python-sdk-docs/python-client.md Signed-off-by: Bernd Verst <[email protected]> --------- Signed-off-by: Elena Kolevska <[email protected]> Signed-off-by: Bernd Verst <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Elena Kolevska <[email protected]> # Conflicts: # dapr/clients/__init__.py # dapr/clients/http/client.py # dapr/clients/http/dapr_invocation_http_client.py # tests/clients/test_http_service_invocation_client.py # tests/clients/test_secure_http_service_invocation_client.py * Runs ruff Signed-off-by: Elena Kolevska <[email protected]> --------- Signed-off-by: Elena Kolevska <[email protected]>
berndverst
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Fixes http endpoint being overwritten by gRPC address argument in constructor (#621) * Fixes bug of constructor argument being used as http endpoint Signed-off-by: Elena Kolevska <[email protected]> * Updates tests Signed-off-by: Elena Kolevska <[email protected]> * Updates the docs explaining how http service invocation should be configured Signed-off-by: Elena Kolevska <[email protected]> * Update daprdocs/content/en/python-sdk-docs/python-client.md Signed-off-by: Bernd Verst <[email protected]> --------- Signed-off-by: Elena Kolevska <[email protected]> Signed-off-by: Bernd Verst <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Elena Kolevska <[email protected]> # Conflicts: # dapr/clients/__init__.py # dapr/clients/http/client.py # dapr/clients/http/dapr_invocation_http_client.py # tests/clients/test_http_service_invocation_client.py # tests/clients/test_secure_http_service_invocation_client.py * health decorator - first commit Signed-off-by: Elena Kolevska <[email protected]> * Fixes tests Signed-off-by: Elena Kolevska <[email protected]> * Removes unused imports Signed-off-by: Elena Kolevska <[email protected]> * Ruff format Signed-off-by: Elena Kolevska <[email protected]> * Adds unit test Signed-off-by: Elena Kolevska <[email protected]> * Repalces wait() with @healthcheck decorator in examples Signed-off-by: Elena Kolevska <[email protected]> * Ruff Signed-off-by: Elena Kolevska <[email protected]> * Linter Signed-off-by: Elena Kolevska <[email protected]> * updates heathcheck decorator to use a global var Signed-off-by: Elena Kolevska <[email protected]> * Fixes tests Signed-off-by: Elena Kolevska <[email protected]> * Linter fixes Signed-off-by: Elena Kolevska <[email protected]> * Removes healthcheck from examples Signed-off-by: Elena Kolevska <[email protected]> * Ruff Signed-off-by: Elena Kolevska <[email protected]> * wip Signed-off-by: Elena Kolevska <[email protected]> * wip Signed-off-by: Elena Kolevska <[email protected]> * wip Signed-off-by: Elena Kolevska <[email protected]> * wip Signed-off-by: Elena Kolevska <[email protected]> * Set health timeout to 60 seconds Signed-off-by: Elena Kolevska <[email protected]> * wip Signed-off-by: Elena Kolevska <[email protected]> * Unit tests passing Signed-off-by: Elena Kolevska <[email protected]> * Linter Signed-off-by: Elena Kolevska <[email protected]> * Refactor and cleanup Signed-off-by: Elena Kolevska <[email protected]> * Refactors client tests for speed and readability Signed-off-by: Elena Kolevska <[email protected]> * Small fix Signed-off-by: Elena Kolevska <[email protected]> * Add tests performance improvement for actor tests too Signed-off-by: Elena Kolevska <[email protected]> * Cosmetic touch up Signed-off-by: Elena Kolevska <[email protected]> * Documents the `DAPR_HEALTH_TIMEOUT` environment variable Signed-off-by: Elena Kolevska <[email protected]> * make healthcheck a static method Signed-off-by: Elena Kolevska <[email protected]> --------- Signed-off-by: Elena Kolevska <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes http endpoint being overwritten by gRPC address argument in constructor.
Issue reference
#620
Checklist